Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IT Wallet): [SIW-1960] Scan QR code for remote presentation #6670

Merged
merged 18 commits into from
Feb 6, 2025

Conversation

RiccardoMolinari95
Copy link
Collaborator

@RiccardoMolinari95 RiccardoMolinari95 commented Jan 31, 2025

Short description

This PR introduces the initial implementation of remote presentation, specifically handling QR code scanning.

List of changes proposed in this pull request

  • Created navigator ItwRemoteStackNavigator, param list ItwRemoteParamsList and the necessary routes for the remote presentation feature
  • Introduced a new barcode type: ITW_REMOTE, representing the QR code payload data
  • Implemented a decoder to handle the new barcode type
  • Introduced a new type ItwRemoteQRCodePayload, representing the QR code payload data
  • Added ItwRemoteClaimsDisclosureScreen , which is displayed after scanning the QR code for remote presentation. This screen triggers the start event in the corresponding state machine, passing the QR code payload to initiate the remote presentation flow. (This is a basic implementation, primarily intended to enable navigation and start the flow).
  • Introduced a new state QRCodeValidation in the remote machine, representing the QR code validation step. (This is a draft implementation and may be revised in future developments.)
  • Added a test in the remote machine

How to test

Scan a valid QR code for the remote presentation and check that the loading spinner appears, indicating that the QR code has been processed successfully

Screen.Recording.2025-01-31.at.16.04.55.mov

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 46.34146% with 22 lines in your changes missing coverage. Please review.

Project coverage is 49.94%. Comparing base (506efe0) to head (e01b533).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...remote/screens/ItwRemoteClaimsDisclosureScreen.tsx 17.64% 14 Missing ⚠️
...tion/remote/navigation/ItwRemoteStackNavigator.tsx 44.44% 5 Missing ⚠️
ts/features/barcode/screens/BarcodeScanScreen.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6670      +/-   ##
==========================================
- Coverage   49.94%   49.94%   -0.01%     
==========================================
  Files        1541     1550       +9     
  Lines       32245    32294      +49     
  Branches     7257     7308      +51     
==========================================
+ Hits        16104    16128      +24     
- Misses      16103    16116      +13     
- Partials       38       50      +12     
Files with missing lines Coverage Δ
ts/features/barcode/types/decoders.ts 96.66% <100.00%> (+0.66%) ⬆️
ts/features/itwallet/common/utils/itwUrlUtils.ts 100.00% <100.00%> (ø)
...es/itwallet/presentation/remote/machine/context.ts 100.00% <100.00%> (ø)
...es/itwallet/presentation/remote/machine/machine.ts 66.66% <100.00%> (+16.66%) ⬆️
.../itwallet/presentation/remote/navigation/routes.ts 100.00% <100.00%> (ø)
ts/navigation/AuthenticatedStackNavigator.tsx 17.64% <ø> (ø)
ts/navigation/params/AppParamsList.ts 100.00% <ø> (ø)
ts/features/barcode/screens/BarcodeScanScreen.tsx 1.31% <0.00%> (-0.06%) ⬇️
...tion/remote/navigation/ItwRemoteStackNavigator.tsx 44.44% <44.44%> (ø)
...remote/screens/ItwRemoteClaimsDisclosureScreen.tsx 17.64% <17.64%> (ø)

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506efe0...e01b533. Read the comment docs.

Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gispada gispada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants