-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IT Wallet): [SIW-1960] Scan QR code for remote presentation #6670
feat(IT Wallet): [SIW-1960] Scan QR code for remote presentation #6670
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6670 +/- ##
==========================================
- Coverage 49.94% 49.94% -0.01%
==========================================
Files 1541 1550 +9
Lines 32245 32294 +49
Branches 7257 7308 +51
==========================================
+ Hits 16104 16128 +24
- Misses 16103 16116 +13
- Partials 38 50 +12
... and 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR introduces the initial implementation of remote presentation, specifically handling QR code scanning.
List of changes proposed in this pull request
ItwRemoteStackNavigator
, param listItwRemoteParamsList
and the necessaryroutes
for the remote presentation featureITW_REMOTE
, representing the QR code payload datadecoder
to handle the new barcode typeItwRemoteQRCodePayload
, representing the QR code payload dataItwRemoteClaimsDisclosureScreen
, which is displayed after scanning the QR code for remote presentation. This screen triggers thestart
event in the corresponding state machine, passing the QR code payload to initiate the remote presentation flow. (This is a basic implementation, primarily intended to enable navigation and start the flow).QRCodeValidation
in the remote machine, representing the QR code validation step. (This is a draft implementation and may be revised in future developments.)test
in the remote machineHow to test
Scan a valid QR code for the remote presentation and check that the loading spinner appears, indicating that the QR code has been processed successfully
Screen.Recording.2025-01-31.at.16.04.55.mov