Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IT Wallet): [SIW-2007] Add local FF for offline wallet access #6678

Merged
merged 7 commits into from
Feb 7, 2025

Conversation

mastro993
Copy link
Contributor

Short description

This PR adds a persisted local FF to enable the IT Wallet offline access

List of changes proposed in this pull request

  • Added isItwOfflineAccessEnabled to the persisted preferences reducer
  • Added store migration
  • Added setItwOfflineAccessEnabled action
  • Removed deprecated ITW Playgrounds

How to test

Tests should pass.
Toggle the preference from the Settings → Playgrounds → Documenti su IO and check that it is persisted between app sessions

@mastro993 mastro993 self-assigned this Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 49.94%. Comparing base (7763bd1) to head (643685b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...res/itwallet/playgrounds/screens/ItwPlayground.tsx 0.00% 4 Missing ⚠️
...nds/components/ItwSkeumorphicCredentialSection.tsx 0.00% 3 Missing ⚠️
ts/store/reducers/persistedPreferences.ts 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6678   +/-   ##
=======================================
  Coverage   49.94%   49.94%           
=======================================
  Files        1550     1550           
  Lines       32294    32297    +3     
  Branches     7259     7311   +52     
=======================================
+ Hits        16128    16131    +3     
+ Misses      16128    16116   -12     
- Partials       38       50   +12     
Files with missing lines Coverage Δ
...let/playgrounds/components/ItwLifecycleSection.tsx 7.69% <ø> (ø)
ts/store/actions/persistedPreferences.ts 100.00% <100.00%> (ø)
ts/store/reducers/persistedPreferences.ts 72.58% <50.00%> (-1.56%) ⬇️
...nds/components/ItwSkeumorphicCredentialSection.tsx 21.42% <0.00%> (ø)
...res/itwallet/playgrounds/screens/ItwPlayground.tsx 14.28% <0.00%> (+3.17%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe25ca1...643685b. Read the comment docs.

Copy link
Collaborator

@gispada gispada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants