Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOCOM-2099] Fix a runtime crash when receiving invalid front matter #6697

Draft
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

Vangaorth
Copy link
Contributor

@Vangaorth Vangaorth commented Feb 7, 2025

⚠️ This PR depends on #6690 ⚠️

Short description

This PR fixes a runtime crash when a badly formatted front matter is received.
image

List of changes proposed in this pull request

  • Added a try-catch around the code that was crashing down the app
  • Added missing tests

How to test

Using the io-dev-api-server, use an invalid front matter and check that the application does not crash.

Copy link

dpulls bot commented Feb 10, 2025

🎉 All dependencies have been resolved !

# Conflicts:
#	ts/features/messages/utils/__tests__/ctas.test.ts
#	ts/features/messages/utils/ctas.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant