-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#IOPID-2638] Registry migration #181
base: main
Are you sure you want to change the base?
Conversation
|
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-2638 |
Quality Gate passed for 'Session Manager'Issues Measures |
f53b086
to
7a73a0d
Compare
7a73a0d
to
6679b55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the plan fails when branch check-modules-lock-in-cicd
is used in CI pipeline. Please check
📖 Terraform Plan ('infra/resources/prod') - successTerraform Planmodule.function_lv_autoscale.data.azurerm_linux_function_app.this[0]: Still reading... [10s elapsed]
module.function_lollipop_autoscale.data.azurerm_linux_function_app.this[0]: Still reading... [10s elapsed]
module.function_lollipop_autoscale.data.azurerm_linux_function_app.this[0]: Still reading... [20s elapsed]
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# module.function_lollipop.azurerm_linux_function_app.this will be updated in-place
~ resource "azurerm_linux_function_app" "this" {
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ app_settings = (sensitive value)
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-auth-lollipop-rg-02/providers/Microsoft.Web/sites/io-p-itn-auth-lollipop-func-02"
name = "io-p-itn-auth-lollipop-func-02"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Auth&Identity"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-auth-n-identity-domain/tree/main/infra/resources/prod"
}
# (31 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# module.function_lollipop.azurerm_linux_function_app_slot.this[0] will be updated in-place
~ resource "azurerm_linux_function_app_slot" "this" {
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ app_settings = (sensitive value)
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-auth-lollipop-rg-02/providers/Microsoft.Web/sites/io-p-itn-auth-lollipop-func-02/slots/staging"
name = "staging"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Auth&Identity"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-auth-n-identity-domain/tree/main/infra/resources/prod"
}
# (29 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.function_lollipop.azurerm_subnet.this has moved to module.function_lollipop.azurerm_subnet.this[0]
resource "azurerm_subnet" "this" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-auth-lollipop-func-snet-02"
name = "io-p-itn-auth-lollipop-func-snet-02"
# (11 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.function_lv.azurerm_linux_function_app.this will be updated in-place
~ resource "azurerm_linux_function_app" "this" {
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ app_settings = (sensitive value)
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-auth-lv-rg-01/providers/Microsoft.Web/sites/io-p-itn-auth-lv-func-02"
name = "io-p-itn-auth-lv-func-02"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Auth&Identity"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-auth-n-identity-domain/tree/main/infra/resources/prod"
}
# (31 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# module.function_lv.azurerm_linux_function_app_slot.this[0] will be updated in-place
~ resource "azurerm_linux_function_app_slot" "this" {
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ app_settings = (sensitive value)
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-auth-lv-rg-01/providers/Microsoft.Web/sites/io-p-itn-auth-lv-func-02/slots/staging"
name = "staging"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Auth&Identity"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-auth-n-identity-domain/tree/main/infra/resources/prod"
}
# (29 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.function_lv.azurerm_subnet.this has moved to module.function_lv.azurerm_subnet.this[0]
resource "azurerm_subnet" "this" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-auth-lv-func-snet-02"
name = "io-p-itn-auth-lv-func-snet-02"
# (11 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.function_public.azurerm_linux_function_app.this will be updated in-place
~ resource "azurerm_linux_function_app" "this" {
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ app_settings = (sensitive value)
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-auth-public-rg-01/providers/Microsoft.Web/sites/io-p-itn-auth-public-func-02"
name = "io-p-itn-auth-public-func-02"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Auth&Identity"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-auth-n-identity-domain/tree/main/infra/resources/prod"
}
# (31 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# module.function_public.azurerm_linux_function_app_slot.this[0] will be updated in-place
~ resource "azurerm_linux_function_app_slot" "this" {
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ app_settings = (sensitive value)
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-auth-public-rg-01/providers/Microsoft.Web/sites/io-p-itn-auth-public-func-02/slots/staging"
name = "staging"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Auth&Identity"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-auth-n-identity-domain/tree/main/infra/resources/prod"
}
# (29 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.function_web_profile.azurerm_linux_function_app.this will be updated in-place
~ resource "azurerm_linux_function_app" "this" {
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ app_settings = (sensitive value)
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-auth-webprof-rg-01/providers/Microsoft.Web/sites/io-p-itn-auth-webprof-func-01"
name = "io-p-itn-auth-webprof-func-01"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Auth&Identity"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-auth-n-identity-domain/tree/main/infra/resources/prod"
}
# (31 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# module.function_web_profile.azurerm_linux_function_app_slot.this[0] will be updated in-place
~ resource "azurerm_linux_function_app_slot" "this" {
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ app_settings = (sensitive value)
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-auth-webprof-rg-01/providers/Microsoft.Web/sites/io-p-itn-auth-webprof-func-01/slots/staging"
name = "staging"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Auth&Identity"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-auth-n-identity-domain/tree/main/infra/resources/prod"
}
# (29 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.function_web_profile.azurerm_subnet.this has moved to module.function_web_profile.azurerm_subnet.this[0]
resource "azurerm_subnet" "this" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-auth-webprof-func-snet-01"
name = "io-p-itn-auth-webprof-func-snet-01"
# (11 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 8 to change, 0 to destroy.
Warning: Deprecated Resource
with data.azurerm_app_service_plan.shared_plan_itn,
on data.tf line 35, in data "azurerm_app_service_plan" "shared_plan_itn":
35: data "azurerm_app_service_plan" "shared_plan_itn" {
The `azurerm_app_service_plan` data source has been superseded by the
`azurerm_service_plan` data source. Whilst this resource will continue to be
available in the 2.x and 3.x releases it is feature-frozen for compatibility
purposes, will no longer receive any updates and will be removed in a future
major release of the Azure Provider.
(and 5 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now. |
List of Changes
Migrate modules from Github to Terraform Registry.
Successfully tested with branch
check-modules-lock-in-cicd
, see plan hereMotivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: