Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#169430153,#169410028,#169404707] fixes and improvements #17

Merged
merged 2 commits into from
Oct 31, 2019
Merged

[#169430153,#169410028,#169404707] fixes and improvements #17

merged 2 commits into from
Oct 31, 2019
+31 −19

Conversation

Undermaken
Copy link
Contributor

This PRs does:

  • rename attempts in attemptsLeft (attempts could be confusing)
  • forwarding event name instead of class toString
  • fix module initialization on iOS devices
  • some code refactoring

@Undermaken
rename attempts in attemptsLeft (attemps could be confusing)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
d4c7d8b 
forwarding event name instead of class toString
fix module inizialization on iOS devices
@Undermaken
rename attempts in attemptsLeft (attemps could be confusing)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
1766b35 
forwarding event name instead of class toString
fix module inizialization on iOS devices
@fventola-ipzs fventola-ipzs merged commit cee6368 into ipzs_review Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fventola-ipzs fventola-ipzs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Undermaken @fventola-ipzs