-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOAPPX-454] Use kotlin and okhttp version from the root project #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOAPPX-454 |
kotlin
and okhttp
version from the root projectkotlin
and okhttp
version from the root project
kotlin
and okhttp
version from the root project
Ladirico
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
github-merge-queue bot
pushed a commit
to pagopa/io-app
that referenced
this pull request
Jan 13, 2025
…ions to be used from libraries if needed (#6574) ## Short description > [!WARNING] > This PR depends on pagopa/io-cie-sdk#54 This PR parametrizes the use of `Kotlin` and `OkHttp` versions to be used from libraries if needed. For example by [io-cie-sdk](pagopa/io-cie-sdk#54). ## List of changes proposed in this pull request - Parametrized the use of `Kotlin` and `OkHttp` versions to be used from libraries if needed ## Ho to test Link this PR on your io-app cloned project and try to build the app in a physical device. Then try a EIC+PIN login. ``` 15:45:26: Executing 'installProductionDebug'... Executing tasks: [installProductionDebug] in project /Users/fabiobombardi/Documents/pagopa/io-app/android/app > Task :gradle-plugin:settings-plugin:checkKotlinGradlePluginConfigurationErrors > Task :gradle-plugin:shared:checkKotlinGradlePluginConfigurationErrors > Task :gradle-plugin:shared:compileKotlin UP-TO-DATE > Task :gradle-plugin:shared:compileJava NO-SOURCE > Task :gradle-plugin:shared:processResources NO-SOURCE > Task :gradle-plugin:shared:classes UP-TO-DATE > Task :gradle-plugin:shared:jar UP-TO-DATE > Task :gradle-plugin:settings-plugin:compileKotlin UP-TO-DATE > Task :gradle-plugin:settings-plugin:compileJava NO-SOURCE > Task :gradle-plugin:settings-plugin:pluginDescriptors UP-TO-DATE > Task :gradle-plugin:settings-plugin:processResources UP-TO-DATE > Task :gradle-plugin:settings-plugin:classes UP-TO-DATE > Task :gradle-plugin:settings-plugin:jar UP-TO-DATE > Task :gradle-plugin:react-native-gradle-plugin:checkKotlinGradlePluginConfigurationErrors > Task :gradle-plugin:react-native-gradle-plugin:compileKotlin UP-TO-DATE > Task :gradle-plugin:react-native-gradle-plugin:compileJava NO-SOURCE > Task :gradle-plugin:react-native-gradle-plugin:pluginDescriptors UP-TO-DATE > Task :gradle-plugin:react-native-gradle-plugin:processResources UP-TO-DATE > Task :gradle-plugin:react-native-gradle-plugin:classes UP-TO-DATE > Task :gradle-plugin:react-native-gradle-plugin:jar UP-TO-DATE > Configure project :app Reading env from: .env AGPBI: {"kind":"warning","text":"DSL element 'dexOptions' is obsolete and should be removed.\nIt will be removed in version 8.0 of the Android Gradle plugin.\nUsing it has no effect, and the AndroidGradle plugin optimizes dexing automatically.","sources":[{}]} > Configure project :react-native-cie Module okhttp : 4.9.2 Module kotlin : 1.9.24 > Configure project :react-native-reanimated Android gradle plugin: 8.5.0 Gradle: 8.8 [... ] > Task :app:installProductionDebug Installing APK 'app-production-debug.apk' on 'motorola edge 30 neo - 14' for :app:production-debug Installed on 1 device. Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0. You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins. For more on this, please refer to https://docs.gradle.org/8.8/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation. BUILD SUCCESSFUL in 25s 1194 actionable tasks: 56 executed, 1138 up-to-date Build Analyzer results available 15:45:52: Execution finished 'installProductionDebug'. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR makes the Android part to use
Kotlin
andOkHttp
version from the root project if available.Ho to test
Link this PR on your io-app cloned project and try to build the app in a physical device. Then try a EIC+PIN login.