Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPAE-431] Delete cmsTag field before updating a service #225

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[#IOPAE-431] Delete cmsTag field before updating a service #225

merged 1 commit into from
Jul 7, 2023

Conversation

giamma1295
Copy link
Contributor

@giamma1295 giamma1295 commented Jul 4, 2023 •
edited
Loading

The new io-services-cms has a functionality to sync back and forth the services between the new and the legacy containers:

  • When a service is created/updated using the new APIs it is also written into the legacy container and marked with a field cmsTag
  • When a service is created/updated using the old APIs a CosmosDBTrigger Azure Function will intercept it an write it into the new container but
    only if the cmsTag field is not present, so when a service is updated using the old APIs the "cmsTag" field needs to be removed.

List of Changes

  • Remove cmsTag before updating a service

Motivation and Context

How Has This Been Tested?

Unit Test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giamma1295 giamma1295 requested a review from a team as a code owner July 4, 2023 13:55
@giamma1295 giamma1295 requested review from BurnedMarshal and michaeldisaro and removed request for a team July 4, 2023 13:55
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPAE-431

@StefanoDoc StefanoDoc requested a review from rodoviti July 4, 2023 13:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
45.6% 45.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

giuseppedipinto
giuseppedipinto approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@giuseppedipinto giuseppedipinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppedipinto giuseppedipinto merged commit ac794d2 into master Jul 7, 2023
@giuseppedipinto giuseppedipinto deleted the IOPAE-431-remove-cms-tag branch July 7, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppedipinto giuseppedipinto giuseppedipinto approved these changes

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal BurnedMarshal is a code owner automatically assigned from pagopa/io-backend-contributors

@michaeldisaro michaeldisaro Awaiting requested review from michaeldisaro michaeldisaro is a code owner automatically assigned from pagopa/io-backend-contributors

@rodoviti rodoviti Awaiting requested review from rodoviti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giamma1295 @giuseppedipinto