-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#IOPID-1444] name inside mailvalidation #304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-1444 |
gquadrati
requested changes
Feb 15, 2024
🎉 All dependencies have been resolved ! |
arcogabbo
force-pushed
the
IOPID-1444
branch
from
February 15, 2024 15:12
231f484
to
d615f74
Compare
arcogabbo
force-pushed
the
IOPID-1444
branch
from
February 15, 2024 17:03
2a028f8
to
ee0e606
Compare
arcogabbo
force-pushed
the
IOPID-1444
branch
from
February 16, 2024 14:35
ee0e606
to
1ed61bd
Compare
gquadrati
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The
name
field needs to stay optional in openapi. Unfortunately, theUpsertedProfileOrchestator
is called also in createProfile but we don't want to pass thename
field there. Even if in theUpsertedProfileOrchestrator
we don't call theEmailValidationWithTemplateProcessOrchestrator
if theprofileOperation
equals toCREATED
, the decode of the input would fail.List of Changes
Motivation and Context
add profile name inside validation mail
How Has This Been Tested?
integration test via io-mock
Screenshots (if appropriate):
Types of changes
Checklist: