Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOPID-1444] name inside mailvalidation #304

Merged
merged 13 commits into from
Feb 19, 2024
Merged

[#IOPID-1444] name inside mailvalidation #304

merged 13 commits into from
Feb 19, 2024

Conversation

arcogabbo
Copy link
Contributor

@arcogabbo arcogabbo commented Feb 14, 2024

⚠️ This PR depends on #305, #306 ⚠️

NOTE: The name field needs to stay optional in openapi. Unfortunately, the UpsertedProfileOrchestator is called also in createProfile but we don't want to pass the name field there. Even if in the UpsertedProfileOrchestrator we don't call the EmailValidationWithTemplateProcessOrchestrator if the profileOperation equals to CREATED, the decode of the input would fail.

List of Changes

Motivation and Context

add profile name inside validation mail

How Has This Been Tested?

integration test via io-mock

Screenshots (if appropriate):

image

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1444

Copy link

dpulls bot commented Feb 15, 2024

🎉 All dependencies have been resolved !

@arcogabbo arcogabbo marked this pull request as ready for review February 16, 2024 14:35
@arcogabbo arcogabbo requested a review from a team as a code owner February 16, 2024 14:35
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@arcogabbo arcogabbo merged commit 1a6cb31 into master Feb 19, 2024
4 checks passed
@arcogabbo arcogabbo deleted the IOPID-1444 branch February 19, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants