Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-2411] GetVisibleServices removal from OpenApi #322

Merged
merged 4 commits into from
Nov 27, 2024
Merged

[#IOPID-2411] GetVisibleServices removal from OpenApi #322

merged 4 commits into from
Nov 27, 2024

Conversation

salvatorelaiso
Copy link
Collaborator

List of Changes

  • Remove OpenApi GetVisibleServices section.
  • Remove GetVisibleServices logging level value from host.json

Motivation and Context

The functionality GetVisibleServices was removed

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-2411

@gquadrati
Copy link
Contributor

Please, execute a build to cleanup index.yaml too

@salvatorelaiso
Copy link
Collaborator Author

Please, execute a build to cleanup index.yaml too

Done in d8c65a2

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

gquadrati
gquadrati approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please @rodoviti, can you check this PR? We removed the getVisibleServices endpoint from the openapi

rodoviti
rodoviti approved these changes Oct 23, 2024
View reviewed changes
Copy link

@rodoviti rodoviti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salvatorelaiso salvatorelaiso merged commit a42f14a into master Nov 27, 2024
4 checks passed
@salvatorelaiso salvatorelaiso deleted the IOPID-2411 branch November 27, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodoviti rodoviti rodoviti approved these changes

@gquadrati gquadrati gquadrati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@salvatorelaiso @gquadrati @rodoviti