Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPID-2581] add definitions and configuration to use remote portal links #916

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

Ladirico
Copy link
Contributor

@Ladirico Ladirico commented Jan 9, 2025

Short description

Add definitions and configuration in order to use remote portal base url

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ladirico Ladirico merged commit 487a978 into master Jan 14, 2025
4 checks passed
github-merge-queue bot pushed a commit to pagopa/io-app that referenced this pull request Jan 16, 2025
> [!Warning]
> This PR depends on
pagopa/io-services-metadata#916
pagopa/io-dev-api-server#454
#6579
#6577

> [!Note]
> Need to edit `IO_SERVICES_METADATA_VERSION` ref on
`scripts/generate-api-models.sh` after merge on `io-services-metadata`

## Short description
Add logic to manage the remote urls

## List of changes proposed in this pull request
- Add new ref  to metadata
- Add selector to get the value of remote urls from the cdn
`absolutePortalLinksSelector`
- Add selector to manage the link building (base path from the cdn +
body url) `replaceBaseUrlSelector`
- Edit hardcoded references to `https://io.italia.it/` and
`https://ioapp.it/` using selectors
- Delete **unused** hardcoded references to `https://io.italia.it/` and
`https://ioapp.it/` into the code

## Demo 


https://github.com/user-attachments/assets/62888ce2-5e08-44b4-a521-e3c2c88b54a0


## How to test
Run the application and check that all links are working properly (as-is
operation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants