-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#IP-339] Migrate fp-ts version from 1.x to 2.x #91
Conversation
add A.reduce to remove useless parameter declaration
Example of PR titles that include pivotal stories:
New dependencies added: @pagopa/ts-commonsAuthor: https://www.pagopa.gov.it Description: Shared TypeScript code for the IO project Homepage: https://github.com/pagopa/io-ts-commons#readme
|
replaced array reduce with fp-ts one
Co-authored-by: Daniele Manni <[email protected]>
Co-authored-by: Daniele Manni <[email protected]>
Co-authored-by: Daniele Manni <[email protected]>
…gopa/io-spid-commons into IP-339--migrate-fp-ts-version
@BurnedMarshal are we fine with latest changes? |
removed deprecated 'not' use
merge duplicated 'saml.ts' (into samlUtils.ts)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart latest minor changes. Thanks for the huge work in this PR.
Update fp-ts version from 1.x to 2.x
List of Changes
Update fp-ts, io-ts, ts-commons and openapigen versions.
Fixed compilation errors due to different fp-ts 2.x version mode.
Fixed unit test compilation errors.
Refactor of saml.ts functions.
Motivation and Context
Reduce technical debt and enable dev to use new fp-ts feature.
How Has This Been Tested?
Already existing unit tests.
Types of changes
Checklist: