Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/PN-9620: fix spacing in modal PF/PA/PG for tablet #1166

Merged
merged 14 commits into from
Mar 28, 2024

Conversation

SarahDonvito
Copy link
Contributor

@SarahDonvito SarahDonvito commented Mar 22, 2024

List of changes proposed in this pull request

  • removed isMobile hook where not needed
  • added padding property in DialogTitle, DialogContent and DialogAction with breakpoints
  • fixed direction and size of button in DialogAction

How to test

Login as PF/PG/PA and check in tablet:

  • padding of entire modal: 32px
  • bottom distance between title and body: 16px
  • bottom distance between title actions: 32px
  • bottom distance between title elements in body: 16px

@SarahDonvito SarahDonvito marked this pull request as ready for review March 22, 2024 17:30
@AndreaCimini90 AndreaCimini90 self-assigned this Mar 25, 2024
@AndreaCimini90 AndreaCimini90 self-requested a review March 25, 2024 11:48
@SarahDonvito SarahDonvito marked this pull request as draft March 27, 2024 08:13
@SarahDonvito SarahDonvito marked this pull request as ready for review March 27, 2024 17:06
@AndreaCimini90 AndreaCimini90 self-requested a review March 28, 2024 10:18
@AndreaCimini90 AndreaCimini90 merged commit 2eda2f6 into develop Mar 28, 2024
5 checks passed
@AndreaCimini90 AndreaCimini90 deleted the fix/PN-9620 branch March 28, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants