fix(PN-10623): implement field for senderDenomination #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahDonvito
requested review from
ZorbaDimatteo,
AndreaCimini90 and
a team
as code owners
ZorbaDimatteo
requested changes
Apr 17, 2024
packages/pn-pa-webapp/src/components/NewNotification/PreliminaryInformations.tsx
Outdated
Show resolved
Hide resolved
ZorbaDimatteo
requested changes
Apr 19, 2024
There was a problem hiding this comment.
@SarahDonvito PR is ok, just refactor User type for PA according to new specification from Selfcare/area Riservata https://pagopa.atlassian.net/wiki/spaces/SCP/pages/421661370/Token+Exchange#Schemas
ZorbaDimatteo
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Implemented field for senderDenomination with check on length
List of changes proposed in this pull request
senderDenomination(composed by organization.parentDescription + organization.name) in preliminary informations page and made it requiredHow to test
Login as PA and go to newNotification page. Check field "Ente mittente" is present and has maximum 80 characters.