fix(PN-13485 ) Fix a11y for filter of notification and delegation #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leleOFA
requested review from
ZorbaDimatteo,
AndreaCimini90 and
a team
as code owners
SarahDonvito
changed the title
leleOFA
changed the title
AndreaCimini90
requested changes
Feb 25, 2025
| @@ -9,7 +9,7 @@ export function LoadingOverlay() { | |||
| const loading = useSelector(appStateSelectors.selectLoading); | |||
|
|
|||
| return ( | |||
| <Modal open={loading} sx={{ outline: 0 }} data-testid="loading-spinner"> | |||
| <Modal open={loading} sx={{ outline: 0 }} data-testid="loading-spinner" disableAutoFocus disableRestoreFocus> | |||
There was a problem hiding this comment.
remove the added properties
| @@ -1,4 +1,4 @@ | |||
| import { Fragment } from 'react'; | |||
| import { Fragment } from 'react'; | |||
There was a problem hiding this comment.
restore the old version
| @@ -142,11 +142,12 @@ const DesktopNotifications = ({ | |||
| }; | |||
|
|
|||
| return ( | |||
| <> | |||
| <div aria-live="assertive"> | |||
There was a problem hiding this comment.
restore the old version
| <FilterNotifications | ||
| ref={filterNotificationsRef} | ||
| showFilters={showFilters} | ||
| currentDelegator={currentDelegator} | ||
| lengthOfNotifications={rows.length} |
| @@ -207,6 +207,7 @@ const FilterNotifications = forwardRef(({ showFilters, currentDelegator }: Props | |||
| cleanFilters={cleanFilters} | |||
| filtersApplied={isFilterApplied(filtersCount)} | |||
| isInitialSearch={isInitialSearch} | |||
| lengthOfNotifications={lengthOfNotifications} | |||
| @@ -2,7 +2,7 @@ import { FormikErrors, FormikTouched, FormikValues } from 'formik'; | |||
| import { ChangeEvent, Fragment } from 'react'; | |||
There was a problem hiding this comment.
restore the old version but keep the helperText for the date component
| @@ -196,6 +197,7 @@ const DelegationsOfTheCompany = () => { | |||
| ) => ( | |||
| <li {...props} key={option.id}> | |||
| <Checkbox | |||
| inputProps={{ 'aria-label': option.name, 'aria-live': 'assertive' }} | |||
There was a problem hiding this comment.
why do we need this?
| }, | ||
| marginBottom: isMobile ? '20px' : '0', | ||
| }} | ||
| renderOption={renderOption} | ||
| renderInput={(params) => ( | ||
| <TextField | ||
| role="combobox" |
There was a problem hiding this comment.
the role, aria-autocomplete and aria-expanded should be set automatically by the mui library
| @@ -2,7 +2,7 @@ import { FormikErrors, FormikTouched, FormikValues } from 'formik'; | |||
| import { ChangeEvent, Fragment } from 'react'; | |||
| @@ -405,6 +405,12 @@ const NuovaDelega = () => { | |||
| label={entitySearchLabel(senderInputValue)} | |||
| error={Boolean(getError(touched.enti, errors.enti))} | |||
| helperText={getError(touched.enti, errors.enti)} | |||
| InputProps={{ | |||
There was a problem hiding this comment.
why do we need this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
fix a11y for pf on filter notification and pg for filter of delegation
List of changes proposed in this pull request
How to test
1-insert wrong date and shown message
2-hear summary before and after select a group for filter of notification
3- hear message when click filter button and clear button on notification filter section for pf