feat/pn 13918: remove old version of payment data

packages/pn-data-viz/src/setupTests.ts

@@ -23,7 +23,6 @@ beforeAll(() => {
     SELFCARE_URL_FE_LOGIN: 'https://test.selfcare.pagopa.it/auth/login',
     SELFCARE_BASE_URL: 'https://test.selfcare.pagopa.it',
     SELFCARE_SEND_PROD_ID: 'prod-pn-test',
-    IS_PAYMENT_ENABLED: false,
     MIXPANEL_TOKEN: 'DUMMY',
     IS_MANUAL_SEND_ENABLED: true,
   });

packages/pn-pa-webapp/src/__mocks__/NewNotification.mock.ts

@@ -43,8 +43,6 @@ const newNotificationRecipients: Array<NewNotificationRecipient> = [
     firstName: 'Mario',
     lastName: 'Rossi',
     recipientType: RecipientType.PF,
-    creditorTaxId: '12345678910',
-    noticeCode: '123456789123456788',
     type: DigitalDomicileType.PEC,
     digitalDomicile: '[email protected]',
     address: 'via del corso',
@@ -63,8 +61,6 @@ const newNotificationRecipients: Array<NewNotificationRecipient> = [
     firstName: 'Sara Gallo srl',
     lastName: '',
     recipientType: RecipientType.PG,
-    creditorTaxId: '12345678910',
-    noticeCode: '123456789123456789',
     type: DigitalDomicileType.PEC,
     digitalDomicile: '',
     address: 'via delle cicale',
@@ -155,23 +151,24 @@ const newNotificationF24Standard: NewNotificationDocument = {
   },
 };
 
+export const payments = {
+  [newNotificationRecipients[0].taxId]: {
+    pagoPa: { ...newNotificationPagoPa },
+  },
+  [newNotificationRecipients[1].taxId]: {
+    pagoPa: { ...newNotificationPagoPa },
+    f24: { ...newNotificationF24Standard },
+  },
+};
+
 export const newNotification: NewNotification = {
   abstract: '',
   paProtocolNumber: '12345678910',
   subject: 'Multone esagerato',
   recipients: newNotificationRecipients,
   documents: newNotificationDocuments,
-  payment: {
-    [newNotificationRecipients[0].taxId]: {
-      pagoPa: { ...newNotificationPagoPa },
-    },
-    [newNotificationRecipients[1].taxId]: {
-      pagoPa: { ...newNotificationPagoPa },
-      f24: { ...newNotificationF24Standard },
-    },
-  },
   physicalCommunicationType: PhysicalCommunicationType.REGISTERED_LETTER_890,
-  paymentMode: PaymentModel.PAGO_PA_NOTICE,
+  paymentMode: PaymentModel.NOTHING,
   group: newNotificationGroups[2].id,
   taxonomyCode: '010801N',
   notificationFeePolicy: NotificationFeePolicy.FLAT_RATE,

packages/pn-pa-webapp/src/components/NewNotification/PaymentMethods.tsx

@@ -286,9 +286,9 @@ const PaymentMethods: React.FC<Props> = ({
       dispatch(setPaymentDocuments({ paymentDocuments: formatPaymentDocuments() }));
     },
   }));
-
+  
   return (
-    <form onSubmit={formik.handleSubmit}>
+    <form onSubmit={formik.handleSubmit} data-testid="paymentMethodForm">
       <NewNotificationCard
         noPaper
         isContinueDisabled={!formik.isValid}

packages/pn-pa-webapp/src/components/NewNotification/PreliminaryInformations.tsx

@@ -26,7 +26,6 @@ import { LangCode } from '@pagopa/mui-italia';
 import {
   NewNotification,
   NewNotificationLangOther,
-  PaymentModel,
 } from '../../models/NewNotification';
 import { GroupStatus } from '../../models/user';
 import { useAppDispatch, useAppSelector } from '../../redux/hooks';
@@ -87,7 +86,6 @@ const PreliminaryInformations = ({ notification, onConfirm }: Props) => {
       group: notification.group ?? '',
       taxonomyCode: notification.taxonomyCode || '',
       physicalCommunicationType: notification.physicalCommunicationType || '',
-      paymentMode: notification.paymentMode || (IS_PAYMENT_ENABLED ? '' : PaymentModel.NOTHING),
       lang: notification.lang || (additionalLang ? NewNotificationLangOther : 'it'),
       additionalLang: notification.additionalLang || additionalLang || '',
       additionalSubject: notification.additionalSubject || '',
@@ -111,7 +109,6 @@ const PreliminaryInformations = ({ notification, onConfirm }: Props) => {
       .max(1024, tc('too-long-field-error', { maxLength: 1024 }))
       .matches(dataRegex.noSpaceAtEdges, tc('no-spaces-at-edges')),
     physicalCommunicationType: yup.string().required(),
-    paymentMode: yup.string().required(),
     group: hasGroups ? yup.string().required() : yup.string(),
     taxonomyCode: yup
       .string()
@@ -312,41 +309,6 @@ const PreliminaryInformations = ({ notification, onConfirm }: Props) => {
                 ))}
             </CustomDropdown>
           </FormBox>
-
-          {IS_PAYMENT_ENABLED && (
-            <FormControl margin="normal" fullWidth>
-              <FormLabel id="payment-method-label">
-                <Typography fontWeight={600} fontSize={'16px'}>
-                  {`${t('payment-method')}*`}
-                </Typography>
-              </FormLabel>
-              <RadioGroup
-                aria-labelledby="payment-method-label"
-                name="paymentMode"
-                value={formik.values.paymentMode}
-                onChange={handleChange}
-              >
-                <FormControlLabel
-                  value={PaymentModel.PAGO_PA_NOTICE}
-                  control={<Radio />}
-                  label={t('pagopa-notice')}
-                  data-testid="paymentMethodRadio"
-                />
-                <FormControlLabel
-                  value={PaymentModel.F24}
-                  control={<Radio />}
-                  label={t('f24')}
-                  data-testid="paymentMethodRadio"
-                />
-                <FormControlLabel
-                  value={PaymentModel.NOTHING}
-                  control={<Radio />}
-                  label={t('nothing')}
-                  data-testid="paymentMethodRadio"
-                />
-              </RadioGroup>
-            </FormControl>
-          )}
         </NewNotificationCard>
       </form>
     </ApiErrorWrapper>

packages/pn-pa-webapp/src/components/NewNotification/Recipient.tsx

@@ -22,7 +22,6 @@ import { useAppDispatch } from '../../redux/hooks';
 import { saveRecipients } from '../../redux/newNotification/reducers';
 import {
   denominationLengthAndCharacters,
-  identicalIUV,
   identicalTaxIds,
   requiredStringFieldValidation,
   taxIdDependingOnRecipientType,
@@ -35,8 +34,6 @@ import PhysicalAddress from './PhysicalAddress';
 const singleRecipient = {
   recipientType: RecipientType.PF,
   taxId: '',
-  creditorTaxId: '',
-  noticeCode: '',
   firstName: '',
   lastName: '',
   type: DigitalDomicileType.PEC,
@@ -64,7 +61,6 @@ type Props = {
 };
 
 const Recipient: React.FC<Props> = ({
-  paymentMode,
   onConfirm,
   onPreviousStep,
   recipientsData,
@@ -89,8 +85,7 @@ const Recipient: React.FC<Props> = ({
         }
       : { recipients: [{ ...singleRecipient, idx: 0, id: 'recipient.0' }] };
 
-  const buildRecipientValidationObject = () => {
-    const validationObject = {
+  const buildRecipientValidationObject = () => ({
       recipientType: yup.string(),
       // validazione sulla denominazione (firstName + " " + lastName per PF, firstName per PG)
       // la lunghezza non può superare i 80 caratteri
@@ -160,24 +155,7 @@ const Recipient: React.FC<Props> = ({
       municipality: requiredStringFieldValidation(tc, 256),
       province: requiredStringFieldValidation(tc, 256),
       foreignState: requiredStringFieldValidation(tc),
-    };
-
-    if (paymentMode !== PaymentModel.NOTHING) {
-      return {
-        ...validationObject,
-        creditorTaxId: yup
-          .string()
-          .required(tc('required-field'))
-          .matches(dataRegex.pIva, t('fiscal-code-error')),
-        noticeCode: yup
-          .string()
-          .matches(dataRegex.noticeCode, t('notice-code-error'))
-          .required(tc('required-field')),
-      };
-    }
-
-    return validationObject;
-  };
+    });
 
   const validationSchema = yup.object({
     recipients: yup
@@ -192,20 +170,6 @@ const Recipient: React.FC<Props> = ({
           errors.map((e) => new yup.ValidationError(t(e.messageKey), e.value, e.id))
         );
       })
-      .test('identicalIUV', t('identical-fiscal-codes-error'), (values) => {
-        const errors = identicalIUV(
-          values as Array<NewNotificationRecipient> | undefined,
-          paymentMode
-        );
-        if (errors.length === 0) {
-          return true;
-        }
-        return new yup.ValidationError(
-          errors.map(
-            (e) => new yup.ValidationError(e.messageKey ? t(e.messageKey) : '', e.value, e.id)
-          )
-        );
-      }),
   });
 
   const handleAddRecipient = (values: FormRecipients, setFieldValue: any) => {
@@ -464,33 +428,6 @@ const Recipient: React.FC<Props> = ({
                       />
                     </Grid>
                   </Grid>
-
-                  {paymentMode !== PaymentModel.NOTHING && (
-                    <Grid container columnSpacing={1} rowSpacing={2} marginTop={4}>
-                      <Grid item xs={12} lg={6}>
-                        <FormTextField
-                          keyName={`recipients[${index}].creditorTaxId`}
-                          label={`${t('creditor-fiscal-code')}*`}
-                          values={values}
-                          touched={touched}
-                          errors={errors}
-                          setFieldValue={setFieldValue}
-                          handleBlur={handleBlur}
-                        />
-                      </Grid>
-                      <Grid item xs={12} lg={6}>
-                        <FormTextField
-                          keyName={`recipients[${index}].noticeCode`}
-                          label={`${t('notice-code')}*`}
-                          values={values}
-                          touched={touched}
-                          errors={errors}
-                          setFieldValue={setFieldValue}
-                          handleBlur={handleBlur}
-                        />
-                      </Grid>
-                    </Grid>
-                  )}
                 </FormBox>
                 {values.recipients.length < 5 && values.recipients.length - 1 === index && (
                   <Stack mt={2} direction="row" justifyContent="space-between">

packages/pn-pa-webapp/src/components/NewNotification/__test__/PreliminaryInformations.test.tsx

@@ -32,7 +32,7 @@ import {
   within,
 } from '../../../__test__/test-utils';
 import { apiClient } from '../../../api/apiClients';
-import { NotificationFeePolicy, PaymentModel } from '../../../models/NewNotification';
+import { NotificationFeePolicy } from '../../../models/NewNotification';
 import { NEW_NOTIFICATION_ACTIONS } from '../../../redux/newNotification/actions';
 import PreliminaryInformations from '../PreliminaryInformations';
 
@@ -64,7 +64,6 @@ vi.mock('../../../services/configuration.service', async () => {
 
 const populateForm = async (
   form: HTMLFormElement,
-  hasPayment: boolean,
   organizationName: string = userResponse.organization.name
 ) => {
   await testInput(form, 'paProtocolNumber', newNotification.paProtocolNumber);
@@ -84,10 +83,6 @@ const populateForm = async (
     1,
     true
   );
-
-  if (hasPayment) {
-    await testRadio(form, 'paymentMethodRadio', ['pagopa-notice', 'f24', 'nothing'], 1, true);
-  }
 };
 
 describe('PreliminaryInformations component with payment enabled', async () => {
@@ -142,7 +137,6 @@ describe('PreliminaryInformations component with payment enabled', async () => {
     testFormElements(form, 'taxonomyCode', 'taxonomy-id*');
     testFormElements(form, 'senderDenomination', 'sender-name*');
     testRadio(form, 'comunicationTypeRadio', ['registered-letter-890', 'simple-registered-letter']);
-    testRadio(form, 'paymentMethodRadio', ['pagopa-notice', 'f24', 'nothing']);
     const button = within(form).getByTestId('step-submit');
     expect(button).toBeDisabled();
   });
@@ -195,7 +189,7 @@ describe('PreliminaryInformations component with payment enabled', async () => {
     const form = result.getByTestId('preliminaryInformationsForm') as HTMLFormElement;
     const button = within(form).getByTestId('step-submit');
     expect(button).toBeDisabled();
-    await populateForm(form, true);
+    await populateForm(form);
     expect(button).toBeEnabled();
     fireEvent.click(button);
     await waitFor(() => {
@@ -211,15 +205,15 @@ describe('PreliminaryInformations component with payment enabled', async () => {
         documents: [],
         recipients: [],
         physicalCommunicationType: PhysicalCommunicationType.AR_REGISTERED_LETTER,
-        paymentMode: PaymentModel.F24,
+        paymentMode: '',
         senderDenomination: newNotification.senderDenomination,
         lang: 'it',
         additionalAbstract: '',
         additionalLang: '',
         additionalSubject: '',
       });
     });
-    expect(confirmHandlerMk).toBeCalledTimes(1);
+    expect(confirmHandlerMk).toHaveBeenCalledTimes(1);
   });
 
   it('fills form with invalid values', async () => {
@@ -242,7 +236,7 @@ describe('PreliminaryInformations component with payment enabled', async () => {
       );
     });
     const form = result.getByTestId('preliminaryInformationsForm') as HTMLFormElement;
-    await populateForm(form, true);
+    await populateForm(form);
     // set invalid values
     // paProtocolNumber
     await testInput(form, 'paProtocolNumber', '');
@@ -321,10 +315,6 @@ describe('PreliminaryInformations component with payment enabled', async () => {
       `input[name="physicalCommunicationType"][value="${newNotification.physicalCommunicationType}"]`
     );
     expect(physicalCommunicationType).toBeChecked();
-    const paymentMode = form.querySelector(
-      `input[name="paymentMode"][value="${newNotification.paymentMode}"]`
-    );
-    expect(paymentMode).toBeChecked();
   });
 
   it('errors on api call', async () => {
@@ -397,8 +387,6 @@ describe('PreliminaryInformations Component with payment disabled', async () =>
     });
     expect(result.container).toHaveTextContent(/title/i);
     const form = result.getByTestId('preliminaryInformationsForm') as HTMLFormElement;
-    const paymentMethodRadio = within(form).queryAllByTestId('paymentMethodRadio');
-    expect(paymentMethodRadio).toHaveLength(0);
     const button = within(form).getByTestId('step-submit');
     expect(button).toBeDisabled();
   });
@@ -425,7 +413,7 @@ describe('PreliminaryInformations Component with payment disabled', async () =>
     const form = result.getByTestId('preliminaryInformationsForm') as HTMLFormElement;
     const button = within(form).getByTestId('step-submit');
     expect(button).toBeDisabled();
-    await populateForm(form, false);
+    await populateForm(form);
     expect(button).toBeEnabled();
     fireEvent.click(button);
     await waitFor(() => {
@@ -441,15 +429,15 @@ describe('PreliminaryInformations Component with payment disabled', async () =>
         documents: [],
         recipients: [],
         physicalCommunicationType: PhysicalCommunicationType.AR_REGISTERED_LETTER,
-        paymentMode: PaymentModel.NOTHING,
+        paymentMode: '',
         senderDenomination: newNotification.senderDenomination,
         lang: 'it',
         additionalAbstract: '',
         additionalLang: '',
         additionalSubject: '',
       });
     });
-    expect(confirmHandlerMk).toBeCalledTimes(1);
+    expect(confirmHandlerMk).toHaveBeenCalledTimes(1);
   });
 
   it('set senderDenomination longer than 80 characters', async () => {