Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PN-13840 - Handle previously unhandled errors on sender dashboard #1465

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

alessandrogelmi
Copy link
Collaborator

Short description

Handle previously unhandled errors on the sender dashboard of PA.

List of changes proposed in this pull request

  • Add handling for additional error cases
  • Check the error type: if it is unexpected, mark it as an unknown error
  • Display only errors that have at least one occurrence

How to test

  1. Start PA and navigate to the Statistics page
  2. Use Netify to mock the following API request: https://webapi.dev.notifichedigitali.it/bff/v1/sender-dashboard/dashboard-data-request/PA/... and return the JSON linked to the JIRA issue
  3. Verify that everything works as expected.

@AndreaCimini90 AndreaCimini90 self-requested a review February 12, 2025 12:43
Copy link
Contributor

@AndreaCimini90 AndreaCimini90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alessandrogelmi I only have one doubt regarding the colors chosen. Before merging it I would do a pass with design

@AndreaCimini90 AndreaCimini90 merged commit 1f1fe43 into develop Feb 20, 2025
5 checks passed
@AndreaCimini90 AndreaCimini90 deleted the fix/PN-13840 branch February 20, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants