Feat/PN-13447 Add EmailSmsContactWizard component #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: add tests to verify DefaultDigitalContact new features
test: fix tests not working after changes to DefaultDigitalContact test: add code to verify the error message is shown submitting an empty DefaultDigitalContact
…generic, renaming to PnInfoCard and moving to pn-commons test: fix tests for DigitalContactsCard after refactor test: add tests for PnInfoCard new functionalities
…draft) fix: add useEffect to PnInfoCard to refresh expanded/collapsed initial state
… instances refactor: add rest prop to PnInfoCard refactor: change LegalContacts layout while validating PEC test: fix LegalContacts, SpecialContacts and Contacts.page tests chore: fix LegalContacts translations
… PG) refactor: change DeleteDialog to reflect new figma specs (PF and PG) refactor: change some localization keys to simplify LegalContacts code (PF and PG)
test: fix tests which stop working after localization key changed
…al domicile test: add code to verify DeleteDialog content while disabling digital domicile
refactor: prevent user from accessing digital domicile management page if ddom is not set
feat: add usePreviousLocation hook to manage navigate to previous page replacing history
refactor: change DigitalContactActivation to include EmailSmsContactWizard refactor: add new optional showLabelOnEdit to DigitalContact component refactor: now PnWizard component accepts a callback to handle the exit test: add/change tests for DigitalContactActivation component
…her customize their layout and behaviour test: add and change tests after adding onExit prop on PnWizard
mflauti
requested review from
ZorbaDimatteo,
AndreaCimini90 and
a team
as code owners
AndreaCimini90
changed the base branch from
develop
to
feature/rework_contacts
AndreaCimini90
requested changes
Feb 17, 2025
packages/pn-personafisica-webapp/src/components/Contacts/DigitalContactActivation.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personagiuridica-webapp/src/components/Contacts/DigitalContactActivation.tsx
Outdated
Show resolved
Hide resolved
AndreaCimini90
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR mainly includes the code needed to implement the ability to add/change an email and/or phone number during the digital domicile activation/transfer wizard. Moreover, there were other changes, which were necessary for this part of the application to work properly.
List of changes proposed in this pull request
How to test
Run both pf and pg webapps and verify the behaviour of every single feature listed above is as descibed by specifications. For PF, to test also the IO step you should use uat environment and mock the server response for sercq activation as follows (since sercq send is disabled on uat):