Refactor/Confirmation modal adding special contact + handle PEC in validation on Management Page #1485
+1,090
−194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…been set or pec is validating
…l contact for a sender that already has one set
… into refactor/last-changes
…anager when pec is validating
mflauti
requested review from
ZorbaDimatteo,
AndreaCimini90 and
a team
as code owners
AndreaCimini90
requested changes
Feb 26, 2025
| > | ||
| {onConfirmLabel} | ||
| </Button> | ||
| {slotsProps?.closeButton?.onClick && ( |
There was a problem hiding this comment.
Instead of this use slots as done for wizard component
| {onCloseLabel} | ||
| </Button> | ||
| )} | ||
| {slotsProps?.confirmButton?.onClick && ( |
| import { AddressType, ChannelType, DigitalAddress, Sender } from '../../../models/contacts'; | ||
| import LegalContactAssociationDialog from '../LegalContactAssociationDialog'; | ||
|
|
||
| vi.mock('react-i18next', () => ({ |
There was a problem hiding this comment.
this can be removed
| <ConfirmationModal | ||
| open={open} | ||
| title={t(`special-contacts.legal-association-title${blockConfirmation}`, { ns: 'recapiti' })} | ||
| // slotsProps={slotsProps ?? undefined} |
| <ConfirmationModal | ||
| open={open} | ||
| title={t(`special-contacts.legal-association-title${blockConfirmation}`, { ns: 'recapiti' })} | ||
| // slotsProps={slotsProps ?? undefined} |
| if (oldAddress) { | ||
| setModalOpen({ | ||
| type: ModalType.CONFIRM_LEGAL_ASSOCIATION, | ||
| data: { |
There was a problem hiding this comment.
why do we need pass this data through state and not directly through modal properties?
| if (oldAddress) { | ||
| setModalOpen({ | ||
| type: ModalType.CONFIRM_LEGAL_ASSOCIATION, | ||
| data: { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR contains the code to implement the functionalities described below
List of changes proposed in this pull request