Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix installment constant #91

Conversation

WashingtonViewup
Copy link

@WashingtonViewup WashingtonViewup commented Nov 28, 2017

/**
 * Installment max installment No interest fallback resolver.
 * Using in line 56:32
 * Installment::getData(Requests $request, $properties)
 *                                            ^^^^^^
 *  ...
 *  // setNoInterestInstallmentQuantity
 *	if (!is_null($installment->getNoInterestInstallmentQuantity())) {
 *	    $data[$properties::INSTALLMENT_NO_INTEREST_INSTALLMENT_QUANTITY] = Currency::toDecimal($installment->getNoInterestInstallmentQuantity());
 *                                    ^^^^^^^^^^^^
 * }
 * ...
 * @TODO FIX TO PATTERN
 */

s2it-moscou and others added 2 commits October 18, 2017 08:16
	  Installment max installment No interest fallback resolver.
	  Using in line 56:32
	  Installment::getData(Requests $request, $properties)
	                                             ^^^^^^
@gabriellucius
Copy link
Contributor

Olá @WashingtonViewup !

O valor maxInstallmentNoInterest é usado em outro serviço, portanto seu valor não é o correto para esse cenário.

De qualquer a forma, a correção desse problema já foi feita no #59, por isso vamos fechar seu PR.
Obrigado pela contribuição!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants