Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back Paketo CA Certificates buildpack #99

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Apr 8, 2021

fixes #96

Summary

The CA Certificates buildpack was removed from the Java Native Image buildpack in v4.1.0. Recent version of the CNB lifecycle support buildpack API 0.5 and higher, so we can restore it.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.

@matthyx matthyx requested a review from a team April 8, 2021 06:56
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 8, 2021

CLA Signed

The committers are authorized under a signed CLA.

@ekcasey ekcasey added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels Apr 9, 2021
ekcasey added a commit to paketo-buildpacks/paketo-website that referenced this pull request Apr 9, 2021
@dmikusa
Copy link
Contributor

dmikusa commented Apr 12, 2021

Looks great, thanks. Merging in a sec.

One note for future reference only. The .github/workflows/update-*.yml files are auto-generated, so you don't technically need it here. In this case, the name of the file included should match what is generated by the automation, so worst case the automation will just update/overwrite what's here, which isn't a big deal.

@dmikusa dmikusa merged commit abb864d into paketo-buildpacks:main Apr 12, 2021
@shresthaujjwal
Copy link

Any plans on releasing this change ?

@dmikusa
Copy link
Contributor

dmikusa commented Apr 29, 2021

Yes, but we are holding off on cutting a release for the moment. This is because the next release of the buildpack will also bump GraalVM to 21.1 and we have reports of compatibility problems with that version of GraalVM and Spring apps. The next release of this buildpack is planned to go out in tandem with the next release of Spring Native.

@matthyx
Copy link
Contributor Author

matthyx commented May 26, 2021

Yes, but we are holding off on cutting a release for the moment. This is because the next release of the buildpack will also bump GraalVM to 21.1 and we have reports of compatibility problems with that version of GraalVM and Spring apps. The next release of this buildpack is planned to go out in tandem with the next release of Spring Native.

@dmikusa-pivotal 21.1 is out... any news on the release?

@dmikusa
Copy link
Contributor

dmikusa commented May 26, 2021

@matthyx - Still pending the Spring Native release, which was pushed back a little bit. If you want to use this now, you can specifically override the GraalVM version with pack build -b or if you're using Spring Boot 2.5, there's a similar configuration you can put in your Maven/Gradle config.

You could also check out main and run build your own java-native-image image. You need to run go get github.com/paketo-buildpacks/libpak/cmd/create-package, then create-package --destination ./out --version 5.4.0, then pack buildpack package --path ./out/ paketobuildpacks/java-native-image. You can then pack build -b paketobuildpacks/java-native-image and use the image you generated.

Sorry for the delay. We don't normally hold back this long. We just have a lot of Spring users and want to make sure they continue to have a smooth experience.

@matthyx
Copy link
Contributor Author

matthyx commented May 26, 2021

no worries, thx for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CA Certificates buildpack
4 participants