Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates an Oracle dependency updater #1243

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Creates an Oracle dependency updater #1243

merged 1 commit into from
Dec 7, 2023

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Aug 8, 2023

Summary

This PR creates an Oracle dependency updater. It looks at https://www.oracle.com/java/technologies/downloads/ and scrapes out the latest version numbers for the given type and version branch. Valid types are either jdk or graalvm. It will then fetch the download and calculate all the metadata.

Use Cases

This works for downloading Oracle dependencies. Currently, we're using Foojay for Oracle JDK updates, but I couldn't quickly figure out how to get it to pull down GraalVM updates. I did this instead and the bonus is we're getting updates as soon as they are published by Oracle.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa
Creates an Oracle dependency updater
c5f9d0d 
This PR creates an Oracle dependency updater. It looks at `https://www.oracle.com/java/technologies/downloads/` and scrapes out the latest version numbers for the given type and version branch. Valid types are either `jdk` or `graalvm`. It will then fetch the download and calculate all the metadata.

Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Aug 8, 2023
@dmikusa dmikusa requested a review from a team as a code owner August 8, 2023 03:53
@dmikusa dmikusa added the note:on-hold We can't start working on this issue yet label Aug 8, 2023
@dmikusa dmikusa removed the note:on-hold We can't start working on this issue yet label Dec 7, 2023
@dmikusa
Copy link
Contributor Author

dmikusa commented Dec 7, 2023

We're good to move ahead on this.

anthonydahanne
anthonydahanne approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@anthonydahanne anthonydahanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as along as it works (html scraping) let's keep it that way; when the html changes, we could investigate another provider API such as foojay

@anthonydahanne anthonydahanne merged commit b28c692 into main Dec 7, 2023
@anthonydahanne anthonydahanne deleted the oracle-action branch December 7, 2023 15:36
This was referenced Jan 18, 2024
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydahanne anthonydahanne anthonydahanne approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmikusa @anthonydahanne