Fix Rust Updater #1401
Merged
Fix Rust Updater #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Rust updater looks a Github to pick the latest release. It was using the Github client's `GetLatestRelease` method, however, it looks like the Rust project doesn't cut releases for patch fixes so we have missed some of these updates. This fix will use the Github client to fetch all of the tags and pick the latest release from the tags. There are tags even for patch releases. Signed-off-by: Daniel Mikusa <[email protected]>
dmikusa
added
type:bug
anthonydahanne
approved these changes
Dec 14, 2023
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Rust updater looks a Github to pick the latest release. It was using the Github client's
GetLatestReleasemethod, however, it looks like the Rust project doesn't cut releases for patch fixes so we have missed some of these updates.This fix will use the Github client to fetch all of the tags and pick the latest release from the tags. There are tags even for patch releases.
Use Cases
Bug fix.
Checklist