Two fixes for pipeline-builder #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikusa
added
type:bug
dmikusa
force-pushed
the
fixes
branch
2 times, most recently
from
84b5c11 to
48356c2
Compare
1. Minor fix in update-pipeline.sh. It tries to add the build script even if that might not exist. This causes the job to fail for composite buildpacks. 2. Update create and package buildpack scripts such that they work and run out of the generated buildpack directory. This helps with a pack limitation that does not let you publish images when the `package.toml` file lives outside of the buildpack directory. 2.) fixes the following error: ``` pack -v buildpack package docker.io/dmikusa/rust -c ../package.toml --publish Warning: A new '--target' flag is available to set the platform for the buildpack package, using 'linux' as default Downloading buildpack from URI: file:///Users/dmikusa/Code/OSS/paketo-community/rust Downloading buildpack dependency for platform linux Downloading buildpack from image: docker.io/paketocommunity/rustup:1.11.0 ERROR: packaging dependencies (uri=docker://docker.io/paketocommunity/rustup:1.11.0,image=): extracting from registry docker://docker.io/paketocommunity/rustup:1.11.0: extracting buildpacks from docker.io/paketocommunity/rustup:1.11.0: could not find label io.buildpacks.buildpackage.metadata ``` Signed-off-by: Daniel Mikusa <[email protected]>
octo/create-package.sh
Outdated
| @@ -1,6 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set -euo pipefail | |||
| set -xeuo pipefail | |||
There was a problem hiding this comment.
we keep that in final version (-x) ?
anthonydahanne
approved these changes
Apr 1, 2024
|
🤦 I totally meant to remove that |
Signed-off-by: Daniel Mikusa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix in update-pipeline.sh. It tries to add the build script even if that might not exist. This causes the job to fail for composite buildpacks.
Update create and package buildpack scripts such that they work and run out of the generated buildpack directory. This helps with a pack limitation that does not let you publish images when the
package.tomlfile lives outside of the buildpack directory.2.) fixes the following error: