Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'Docker Login' Step back to support required cases #365

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

pivotal-david-osullivan
Copy link
Contributor

@pivotal-david-osullivan pivotal-david-osullivan commented Sep 3, 2021

Summary

Removing the Docker Login step completely from 'Create Package Test' action caused failures for some composite buildpacks where it is required. This patch adds the step back for non Paketo buildpacks and also adds a check which will not run the Login step if the actor is Dependabot, since it will not have the required credentials to succeed(recommended by Github Support).

Use Cases

The Docker Login step will continue to fail for Dependabot PRs in some composite buildpacks, re-running the action should supply the credentials and the check should then pass.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pivotal-david-osullivan pivotal-david-osullivan requested a review from a team September 3, 2021 12:10
@pivotal-david-osullivan pivotal-david-osullivan added semver:patch A change requiring a patch version bump type:bug A general bug labels Sep 3, 2021
Copy link
Contributor Author

@pivotal-david-osullivan pivotal-david-osullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmikusa-pivotal Could I get your eyes on this please before I cut a release, validate & roll out?
I had to change the conditional logic a bit to still support the old checks (e.g. no forks) and add the Dependabot actor check

Copy link
Contributor

@dmikusa dmikusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic seems good to me. You have the same logic as before &&'d with is_not_dependabot. So every case that was previously true will only be true if the actor is not dependabot. Every case that was previously false will still be false regardless of the actor. Anything submitted by dependabot will always be false. I think that's what we want.

@pivotal-david-osullivan pivotal-david-osullivan merged commit 2a2ed22 into main Sep 3, 2021
@pivotal-david-osullivan pivotal-david-osullivan deleted the add_docker_step_conditionally branch September 3, 2021 13:08
This was referenced Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants