Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make processes direct for Jammy Tiny stack #114

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Conversation

fg-j
Copy link

@fg-j fg-j commented Jun 23, 2022

Summary

Blocked by paketo-buildpacks/libpak#150.
This buildpack should use direct processes when either the bionic or jammy tiny stacks are being used, since neither include a shell in their run image.

Resolves #111

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

not only when bionic tiny stack is used
@fg-j fg-j requested a review from a team as a code owner June 23, 2022 18:19
ForestEckhardt
ForestEckhardt previously approved these changes Jun 28, 2022
@ForestEckhardt ForestEckhardt dismissed their stale review June 28, 2022 15:44

Did not see blocked status before approval

@dmikusa
Copy link
Contributor

dmikusa commented Jun 28, 2022

FYI, @pivotal-david-osullivan and I discussed and the plan is to cut a libpak release early next week. That should unblock this PR.

@fg-j
Copy link
Author

fg-j commented Jul 7, 2022

Ping @dmikusa-pivotal and @pivotal-david-osullivan!

@dmikusa
Copy link
Contributor

dmikusa commented Jul 7, 2022

Apologizes, this got delayed a bit. We're targeting Mon for the libpak release now.

@dmikusa
Copy link
Contributor

dmikusa commented Jul 11, 2022

OK, we just cut this release, it should be available in 5-10 mins. https://github.com/paketo-buildpacks/libpak/releases/tag/v1.61.0.

If you want to manually bump to 1.61.0 in the go.mod file of your PR, that should make all the tests pass. Alternatively, we can bump go.mod when dependabot runs over the next 24 hrs and you can rebase your PR. Either way is fine by me.

@ForestEckhardt ForestEckhardt added type:enhancement A general enhancement semver:patch A change requiring a patch version bump semver:minor A change requiring a minor version bump and removed status:blocked semver:patch A change requiring a patch version bump labels Jul 12, 2022
@ForestEckhardt ForestEckhardt merged commit a5c31ad into main Jul 12, 2022
@ForestEckhardt ForestEckhardt deleted the add-jammy-tiny branch July 12, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support Jammy Tiny stack
3 participants