Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose the merge of static, tiny and base stacks and builders #313

Merged
merged 13 commits into from
Jan 25, 2025

Conversation

loewenstein-sap
Copy link
Contributor

@loewenstein-sap loewenstein-sap commented Dec 16, 2024

@loewenstein-sap loewenstein-sap requested a review from a team as a code owner December 16, 2024 15:23
@loewenstein-sap loewenstein-sap requested review from a team December 16, 2024 15:24
Copy link
Contributor

@dmikusa dmikusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. The simplification it proposes is good. I like that is can represent a reduction in work/effort as well. I posted some initial thoughts/questions to get this conversation going.

text/0000-core-builder.md Outdated Show resolved Hide resolved
text/0000-core-builder.md Outdated Show resolved Hide resolved
text/0000-core-builder.md Outdated Show resolved Hide resolved
text/0000-core-builder.md Outdated Show resolved Hide resolved
text/0000-core-builder.md Outdated Show resolved Hide resolved
text/0000-core-builder.md Outdated Show resolved Hide resolved
text/0000-core-builder.md Outdated Show resolved Hide resolved
text/0000-core-builder.md Outdated Show resolved Hide resolved
text/0000-core-builder.md Outdated Show resolved Hide resolved
text/0000-core-builder.md Outdated Show resolved Hide resolved
text/0000-core-builder.md Outdated Show resolved Hide resolved
@anthonydahanne
Copy link
Member

Since specific language builders are explicitly not threatened by this RFC, and for the sake of simplification, fine by me!

@loewenstein-sap
Copy link
Contributor Author

After ff8bafd, there doesn't seem to be too many things open here, so I would hope we can soon call for a final commenting period. WDYT @paketo-buildpacks/steering-committee?

@robdimsdale Are you still active in the @paketo-buildpacks/builders-maintainers team? Would be great if you could chime in and comment.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea, and I'm ok with starting where the default image is the large one/covers all cases one.

I think the automation that @pacostas has done for the ubi stack should make it relatively easy to implement as well.

LGTM

@loewenstein-sap
Copy link
Contributor Author

@paketo-buildpacks/steering-committee time to merge?

@dmikusa
Copy link
Contributor

dmikusa commented Jan 21, 2025

I'm fine with it. We have two-thirds of the steering committee voting 👍 as well as one member of stacks/builders team. Let's start the final call for comments. If no concerns are raised by Friday 2025-1-24, then we'll merge this.

@ForestEckhardt @robdimsdale Any thoughts on this one?

@dmikusa
Copy link
Contributor

dmikusa commented Jan 25, 2025

Seeing no further feedback, this is approved and I'm going to merge.

@dmikusa dmikusa merged commit c90d757 into main Jan 25, 2025
1 check passed
@dmikusa dmikusa deleted the ubuntu-core-builder branch January 25, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants