Docker Login Improvements #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebhale
added
semver:patch
nebhale
force-pushed
the
pull-request-target
branch
3 times, most recently
from
b68b5f0 to
54b7b5a
Compare
Previously the Docker Login step in many of the workflows was executed regardless of whether it was necessary. This would have been find except that the required secrets were not available in PRs from forks. This change removes the Docker Login steps from where it is not necessary and puts a guard on its execution in workflows that are run as part of PRs. Signed-off-by: Ben Hale <[email protected]>
nebhale
force-pushed
the
pull-request-target
branch
from
54b7b5a to
76cb970
Compare
ekcasey
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Docker Login step in many of the workflows was executed regardless of whether it was necessary. This would have been find except that the required secrets were not available in PRs from forks. This change removes the Docker Login steps from where it is not necessary and puts a guard on its execution in workflows that are run as part of PRs.