Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Numeric input round value at first render #3837

Closed
wants to merge 2 commits into from

Conversation

raphdpx
Copy link

@raphdpx raphdpx commented Nov 12, 2019

Changes proposed in this pull request:

Numeric Input round the value with the getSanitizedValue function to the precision of minorStepsize if the value is declared, if not it takes the Stepsize value. Previously, the value was round to precision 0 when the input was rendered.

Reviewers should focus on:

Numeric input render, value with decimals and decimals stepsize / minorstepsize.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @raphdpx! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@adidahiya
Copy link
Contributor

In general I recommend you first file a bug report using the issue template so that we can understand the exact problem you're having. Also for changes like this I would like to see unit tests added.

@adidahiya
Copy link
Contributor

superseded by #3894

@adidahiya adidahiya closed this Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants