Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] [core] fix: color palette revision #4993

Closed
wants to merge 2 commits into from
Closed

[v4] [core] fix: color palette revision #4993

wants to merge 2 commits into from

Conversation

aycai
Copy link
Contributor

@aycai aycai commented Oct 28, 2021 •
edited by adidahiya
Loading

Changes proposed in this pull request:

Color revision:

  • $gray1 barely fails contrast on $light-gray4. Tweak should fix that.
    image

  • Toned down blue and red to better support background use (they are currently very bright).
    image

  • Added saturation to $orange3 and `$orange5.
    image

  • Shifted green hue very slightly from 145 to 148.
    image

Reviewers should focus on:

Correct file changes

Screenshot

(See above)

@adidahiya adidahiya self-assigned this Oct 28, 2021
@adidahiya adidahiya changed the title [v4] Color palette revision [v4] [core] fix: color palette revision Oct 28, 2021
@adidahiya
Copy link
Contributor

docs preview

@adidahiya
Copy link
Contributor

This is actually the wrong target branch. you need to update these colors on next. I'll move the changes over and open a new PR.

@adidahiya adidahiya closed this Oct 29, 2021
@adidahiya adidahiya mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adidahiya adidahiya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aycai @adidahiya