-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[icons] feat: new icons fuel, playbook #5192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: the current error message for undefined codepoints is not great, I will fix this to make it more legible:
Error: [generate-icon-fonts] Invalid metadata entry in icons.json: icon "playbook" cannot have codepoint undefined, it is already in use.
resources/icons/20px/playbook.svg
Outdated
</g> | ||
<defs> | ||
<clipPath id="clip0_328_94"> | ||
<rect width="20" height="20" fill="white"/> | ||
</clipPath> | ||
</defs> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this <defs>
is extraneous
</g> | |
<defs> | |
<clipPath id="clip0_328_94"> | |
<rect width="20" height="20" fill="white"/> | |
</clipPath> | |
</defs> | |
</g> |
Co-authored-by: Adi Dahiya <[email protected]>
Co-authored-by: Adi Dahiya <[email protected]>
@adidahiya I updated it according to your suggestions. Hopefully it should be good now, if not I'll ask one of my devs to help. |
looks good in docs preview 👍🏽 |
Fixes #0000
Checklist
Changes proposed in this pull request:
Added icons for 'fuel' and 'playbook'
Reviewers should focus on:
Making sure everything renders correctly and the right files were changed