[icons] feat: 7 new icons #5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplication, divide
adidahiya
changed the title
adidahiya
suggested changes
Mar 31, 2022
There was a problem hiding this comment.
icons look good but I have some naming suggestions. "card" feels a little too specific, I think this could more generally represent a "rectangle". also "fill" is a little too generic... alternative names I found for this one include "fill-color", "color-fill", and "paint-bucket", and I'm suggesting we use the former.
when you rename the icons, please remember to rename the SVG files too :)
packages/icons/icons.json
Outdated
Comment on lines
3860
to
3861
| "displayName": "Color fill", | ||
| "iconName": "fill", |
There was a problem hiding this comment.
Suggested change
| "displayName": "Color fill", | |
| "iconName": "fill", | |
| "displayName": "Fill color", | |
| "iconName": "fill-color", |
packages/icons/icons.json
Outdated
Comment on lines
3839
to
3840
| "displayName": "Card height", | ||
| "iconName": "card-height", |
There was a problem hiding this comment.
Suggested change
| "displayName": "Card height", | |
| "iconName": "card-height", | |
| "displayName": "Rectangle height", | |
| "iconName": "rect-height", |
packages/icons/icons.json
Outdated
Comment on lines
3846
to
3847
| "displayName": "Card width", | ||
| "iconName": "card-width", |
There was a problem hiding this comment.
Suggested change
| "displayName": "Card width", | |
| "iconName": "card-width", | |
| "displayName": "Rectangle width", | |
| "iconName": "rect-width", |
adidahiya
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
card size, padding inbetween, fill bucket, open application, divide
Changes proposed in this pull request:
Added:
Reviewers should focus on:
Making sure everything renders correctly and the right files were changed
Screenshot