-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow for additional props on nonIdealState #5356
allow for additional props on nonIdealState #5356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will, but just to be sure, it's good practice to add code to this repo which demonstrates usage of your new feature, and checks that it compiles correctly at build time. Please add an representative example of this new feature to one of the NonIdealState examples, perhaps |
great point. added to one of the examples. |
@@ -126,6 +126,7 @@ export class NonIdealStateExample extends React.PureComponent<IExampleProps, INo | |||
description={this.state.showDescription ? description : undefined} | |||
action={this.state.showAction ? action : undefined} | |||
layout={this.state.layout} | |||
role="alert" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this example does not show an urgent, time-sensitive message, so this role is inappropriate.
to be honest I don't see any role in the list here which would be appropriate for a NonIdealState. so that begs the question, why are we adding this feature or demonstrating a <NonIdealState>
example using the role
attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can just cancel this PR
Fixes #0000
Checklist
Changes proposed in this pull request:
Allow additional html props to be passed to nonIdealState. Allows user to set
role
, or other props.