Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migration APIs to drop 'I' interface prefix #5506

Merged
merged 4 commits into from
Aug 22, 2022
Merged

feat: migration APIs to drop 'I' interface prefix #5506

merged 4 commits into from
Aug 22, 2022

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Aug 22, 2022 •
edited
Loading

Changes proposed in this pull request:

This PR adds the final remaining migration APIs which will allow us to fully drop the "I" interface name prefixes in Blueprint v5.0:

  • [core] ❌ IToaster -> ToasterInstance
  • [core] ❌ IToastProps -> ToastProps
    • N.B. this was already available before this PR, but the old name was not deprecated yet
  • [docs-theme] ❌ IExampleProps -> ExampleProps
  • [select] ❌ IItemRendererProps -> ItemRendererProps
  • [select] ❌ IItemListRendererProps -> ItemListRendererProps
  • [select] ❌ IListItemsProps -> ListItemsProps
  • [select] ❌ ICreateNewItem -> CreateNewItem

@blueprint-bot
Copy link

feat: migration APIs to drop 'I' interface prefix

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

Fix lint

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

fix lint

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit 7a6320c into develop Aug 22, 2022
@adidahiya adidahiya deleted the ad/final-migration-apis branch August 22, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adidahiya @blueprint-bot