fix bug related to ticket #6703 placeholder not updating due to wrong…

[sc-mitton]

… focus state

Fixes #6703

Fix a bug where the value isn't updating from controlled input.

[palantirtech]

Thanks for your interest in palantir/blueprint, @sc-mitton! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[changelog-app]

Generate changelog in packages/datetime2/changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

fix bug related to ticket #6703 placeholder not updating due to wrong…

Check the box to generate changelog(s)

• Generate changelog entry

[ggdouglas]

This seems to fix the bug where a controlled prop passed to DateInput3 is set to a particular value, but it still seems to miss when the value is cleared, e.g.

Can we also handle that related case here?

I think it should be a matter of affecting one of the useEffects above to handle the case where valueFromProps gets set to to a nullish value. Something like:

React.useEffect(() => {
    if (isControlled || valueFromProps == null) {
        setValue(valueFromProps);
    }
}, [isControlled, valueFromProps]);

[sc-mitton]

const isControlled = valueFromProps !== undefined;

The isControlled variable is already defined as valueFromProps !== undefined. So isControlled || valueFromProps == null would be redundant no? If valueFromProps == null is true, then isControlled is already true.

[sc-mitton]

I'm also not having this issue you mentioned in my local dev. In the hook you mentioned the value should be cleared.