Excavator: Upgrades Baseline to the latest version

palantir · Sep 16, 2019 · 5d7b960 · 5d7b960
1 parent 03a47c0
commit 5d7b960
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.baseline/checkstyle/checkstyle.xml b/.baseline/checkstyle/checkstyle.xml
@@ -422,6 +422,7 @@
             <property name="allowEmptyMethods" value="true"/>
             <property name="allowEmptyTypes" value="true"/>
             <property name="allowEmptyLoops" value="true"/>
+            <property name="allowEmptyLambdas" value="true"/>
             <property name="ignoreEnhancedForColon" value="false"/>
             <message key="ws.notFollowed" value="WhitespaceAround: ''{0}'' is not followed by whitespace. Empty blocks may only be represented as '{}' when not part of a multi-block statement (4.1.3)"/>
             <message key="ws.notPreceded" value="WhitespaceAround: ''{0}'' is not preceded with whitespace."/>
@@ -435,7 +436,7 @@
         </module>
         <module name="CyclomaticComplexity"/> <!-- Java Coding Guidelines: Reduce Cyclomatic Complexity -->
         <module name="DesignForExtension"> <!-- Java Coding Guidelines: Design for extension -->
-            <property name="ignoredAnnotations" value="Test, Before, BeforeEach, After, AfterEach, BeforeClass, BeforeAll, AfterClass, AfterAll"/>
+            <property name="ignoredAnnotations" value="ParameterizedTest, Test, Before, BeforeEach, After, AfterEach, BeforeClass, BeforeAll, AfterClass, AfterAll"/>
         </module>
         <module name="JavadocMethod"> <!-- Java Style Guide: Where Javadoc is used -->
             <property name="scope" value="public"/>

diff --git a/build.gradle b/build.gradle
@@ -9,7 +9,7 @@ buildscript {
         classpath 'com.netflix.nebula:gradle-info-plugin:5.0.3'
         classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4'
         classpath 'com.netflix.nebula:nebula-publishing-plugin:13.4.1'
-        classpath 'com.palantir.baseline:gradle-baseline-java:0.57.0'
+        classpath 'com.palantir.baseline:gradle-baseline-java:2.5.0'
         classpath 'com.palantir.gradle.consistentversions:gradle-consistent-versions:1.11.2'
     }
 }

diff --git a/ssl-config/src/main/java/com/palantir/conjure/java/api/config/ssl/SslConfiguration.java b/ssl-config/src/main/java/com/palantir/conjure/java/api/config/ssl/SslConfiguration.java
@@ -18,6 +18,7 @@
 
 import com.fasterxml.jackson.annotation.JsonAlias;
 import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
+import com.palantir.logsafe.exceptions.SafeIllegalArgumentException;
 import java.nio.file.Path;
 import java.util.Optional;
 import org.immutables.value.Value;
@@ -66,11 +67,11 @@ public StoreType keyStoreType() {
     @Value.Check
     protected final void check() {
         if (keyStorePath().isPresent() != keyStorePassword().isPresent()) {
-            throw new IllegalArgumentException(
+            throw new SafeIllegalArgumentException(
                     "keyStorePath and keyStorePassword must both be present or both be absent");
         }
         if (keyStoreKeyAlias().isPresent() && !keyStorePath().isPresent()) {
-            throw new IllegalArgumentException(
+            throw new SafeIllegalArgumentException(
                     "keyStorePath must be present if keyStoreKeyAlias is present");
         }
     }