RemoteException emits more safeargs #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
commented
Apr 28, 2021
| @@ -49,7 +53,10 @@ public RemoteException(SerializableError error, int status) { | |||
| this.message = this.stableMessage + " with instance ID " + error.errorInstanceId(); | |||
| this.error = error; | |||
| this.status = status; | |||
| this.args = Collections.singletonList(SafeArg.of("errorInstanceId", error.errorInstanceId())); | |||
| this.args = Collections.unmodifiableList(Arrays.asList( | |||
There was a problem hiding this comment.
ImmutableList is off the cards cos this project doens't seem to depend on guava, and we still have sourceCompat = 1.8 here so no List.of either.
carterkozak
approved these changes
Apr 28, 2021
|
Released 2.18.0 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Context in #dev-rpc - BLUF is that logs in aries are hard to filter when there are many RemoteExceptions, but they have different causes.
After this PR
==COMMIT_MSG==
RemoteExceptions now emit SafeArgs for
errorInstanceId,errorCodeanderrorName(previously it was justerrorInstanceId)==COMMIT_MSG==
Possible downsides?