[stacked] Stop using #[async_trait] in conjure-macros #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Async custom clients and endpoints traits had to use the
#[async_trait]
macro.After this PR
==COMMIT_MSG==
Async custom clients and endpoints no longer use the
#[async_trait]
macro.==COMMIT_MSG==
Possible downsides?
Due to the lack of support for applying bounds to the anonymous future return types, the macro currently rewrites the trait definitions to add
Send
bounds to the trait definition. Still an improvement over#[async_trait]
though.