Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stacked] Stop using #[async_trait] in conjure-macros #281

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

sfackler
Copy link
Member

@sfackler sfackler commented Jan 6, 2024

Before this PR

Async custom clients and endpoints traits had to use the #[async_trait] macro.

After this PR

==COMMIT_MSG==
Async custom clients and endpoints no longer use the #[async_trait] macro.
==COMMIT_MSG==

Possible downsides?

Due to the lack of support for applying bounds to the anonymous future return types, the macro currently rewrites the trait definitions to add Send bounds to the trait definition. Still an improvement over #[async_trait] though.

@sfackler sfackler force-pushed the no-async-trait branch 2 times, most recently from 91fda14 to 90e2c1b Compare January 7, 2024 15:52
@sfackler sfackler force-pushed the no-macro-async-trait branch from 75c0dc7 to a21dbc1 Compare January 8, 2024 00:48
TheKeveloper
TheKeveloper previously approved these changes Jan 22, 2024
Base automatically changed from no-async-trait to master January 23, 2024 14:22
@changelog-app
Copy link

changelog-app bot commented Jan 23, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Async custom clients and endpoints no longer use the #[async_trait] macro.

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 5459227 into master Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants