Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bytes::Bytes for binary #345

Merged
merged 3 commits into from
Apr 21, 2024
Merged

Use bytes::Bytes for binary #345

merged 3 commits into from
Apr 21, 2024

Conversation

sfackler
Copy link
Member

@sfackler sfackler commented Apr 21, 2024

Before this PR

The Conjure binary type was backed by Vec<u8>.

After this PR

==COMMIT_MSG==
The Conjure binary type is now backed by bytes::Bytes.
==COMMIT_MSG==

We already use Bytes in the conjure_http interfaces, and this more generally supports some zero-copy workflows.

Closes #340

@changelog-app
Copy link

changelog-app bot commented Apr 21, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

The Conjure binary type is now backed by bytes::Bytes.

Check the box to generate changelog(s)

  • Generate changelog entry

@sfackler sfackler merged commit e5d6df3 into master Apr 21, 2024
5 checks passed
@sfackler sfackler deleted the bytes branch April 21, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use bytes::Bytes instead of ByteBuf/Vec<u8> for bytes values.
3 participants