Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom backtrace for conjure error #361

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

wsuppiger
Copy link

Before this PR

After this PR

==COMMIT_MSG==
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Jun 12, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add custom backtrace for conjure error

Check the box to generate changelog(s)

  • Generate changelog entry

@wsuppiger wsuppiger requested a review from sfackler June 12, 2024 19:29
@@ -392,17 +399,30 @@ impl<'a> Iterator for ParamsIter<'a> {

/// A backtrace associated with an `Error`.
// FIXME remove in favor of std backtrace directly in next major bump
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this FIXME now that our type also supports custom traces.

@sfackler sfackler merged commit f22bbf1 into master Jun 12, 2024
5 checks passed
@sfackler sfackler deleted the wsuppiger/add-custom-trace branch June 12, 2024 19:41
@autorelease3
Copy link

autorelease3 bot commented Jun 12, 2024

Released 4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants