Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept productName/productVersion flags #70

Merged
merged 3 commits into from
Sep 6, 2019
Merged

Accept productName/productVersion flags #70

merged 3 commits into from
Sep 6, 2019

Conversation

sfackler
Copy link
Member

@sfackler sfackler commented Sep 6, 2019

Before this PR

This generator couldn't be used with the Gradle conjure-local plugin because it always passes --productName and --productVersion flags.

After this PR

==COMMIT_MSG==
The generator now accepts --productName and --productVersion flags as aliases for --crateName and --crateVersion respectively.
==COMMIT_MSG==

@sfackler sfackler requested a review from ferozco September 6, 2019 19:43
@changelog-app
Copy link

changelog-app bot commented Sep 6, 2019

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

The generator now accepts --productName and --productVersion flags as aliases for --crateName and --crateVersion respectively.

Check the box to generate changelog(s)

  • Generate changelog entry

@ferozco
Copy link

ferozco commented Sep 6, 2019

👍

@sfackler sfackler merged commit 64a4d9a into master Sep 6, 2019
@sfackler sfackler deleted the product-alias branch September 6, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants