Support asynchronous clients and servers #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to async/await the implementation and API of async clients is pretty close to the API of the sync clients! This means that almost all of the codegen is shared, with a flag passed around to make the few changes we need here and there.
bavardage
approved these changes
Oct 15, 2019
|
Yep |
sfackler
changed the title
|
Added support for async servers as well. |
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
This isn't absolutely required, and unblocks a release. We'll add the impls back once tokio cuts a stable release.
sfackler
commented
Nov 8, 2019
| @@ -53,6 +55,37 @@ pub trait Client { | |||
| U: VisitResponse<Self::BinaryBody>; | |||
| } | |||
|
|
|||
| /// A trait implemented by async HTTP client implementations. | |||
| pub trait AsyncClient { | |||
There was a problem hiding this comment.
There's a rustc bug that prevents us from using #[async_trait] for this, but that's not a huge deal since we don't expect many things to actually have to implement this. rust-lang/rust#63033
There was a problem hiding this comment.
There was a problem hiding this comment.
All implementations of that should be generated by conjure-codegen, so there's no real need to make it ergonomic.
bavardage
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to async/await the implementation and API of async clients is
pretty close to the API of the sync clients! This means that almost all
of the codegen is shared, with a flag passed around to make the few
changes we need here and there.