Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conjure-imports example in conjure_definitions.md #799

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Fix conjure-imports example in conjure_definitions.md #799

merged 1 commit into from
Feb 2, 2021

Conversation

glynternet
Copy link
Contributor

Before this PR

The following exception would occur whilst compiling the example.

com.palantir.logsafe.exceptions.SafeIllegalArgumentException: Unrecognized definition, types must have either fields, values or an alias defined.

After this PR

When compiling just the example.yml and common.yml there is a NullPointerException, but at least the definition can be parsed properly.

@policy-bot policy-bot bot requested a review from ferozco February 1, 2021 10:10
@glynternet glynternet changed the title Update conjure_definitions.md Fix conjure-imports example in README Feb 1, 2021
@glynternet glynternet changed the title Fix conjure-imports example in README Fix conjure-imports example in conjure_definitions.md Feb 1, 2021
carterkozak
carterkozak approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bulldozer-bot bulldozer-bot bot merged commit c58ed27 into master Feb 2, 2021
@bulldozer-bot bulldozer-bot bot deleted the glynternet-patch-1 branch February 2, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak carterkozak approved these changes

@ferozco ferozco Awaiting requested review from ferozco

Assignees
No one assigned
Labels
merge when ready no changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glynternet @carterkozak