Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueuedChannel enforces its assumption around at least one in-flight request #2422

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

carterkozak
Copy link
Contributor

@carterkozak carterkozak commented Nov 14, 2024

WIP, need to clean up tests, and figure out what's up with the simulations

==COMMIT_MSG==
QueuedChannel enforces its assumption around at least one in-flight request
==COMMIT_MSG==

For posterity:

The changes to the simulations in this PR can be avoided by implementing a recursive-scheduling check like this: #2424
Are we necessarily better off with that check? I'm not sure, threadlocals are a massive pain, so at the moment I think I'd prefer this behavior.

@changelog-app
Copy link

changelog-app bot commented Nov 14, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

QueuedChannel enforces its assumption around at least one in-flight request

Check the box to generate changelog(s)

  • Generate changelog entry

@carterkozak carterkozak requested a review from bjlaub November 15, 2024 15:47
@carterkozak carterkozak marked this pull request as ready for review November 15, 2024 16:27
@bulldozer-bot bulldozer-bot bot merged commit 7074d6e into develop Nov 18, 2024
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/queued_channel_assumptions branch November 18, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants