Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR Validate SafeLoggable throwables are created with constant message strings #508

Closed
carterkozak opened this issue Jan 16, 2019 · 2 comments
Closed

FR Validate SafeLoggable throwables are created with constant message strings #508

carterkozak opened this issue Jan 16, 2019 · 2 comments
Assignees
@dsd987
Labels
error-prone request

Comments

@carterkozak
Copy link
Contributor

What happened?

We do not validate against thow new SafeIllegalStateException("Hello " + name)

What did you want to happen?

Validation should match what is applied to the safe-logging preconditions "factory" methods.
@carterkozak
Copy link
Contributor Author

We have checks that recommend switching exceptions with constant-string messages to safe-logging, but we are missing checks to enforce that messages stay constant across future changes.

@carterkozak
Copy link
Contributor Author

I think this is fixed by palantir/safe-logging#104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsd987 dsd987

Labels
error-prone request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsd987 @carterkozak