Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop RedundantModifier to SUGGESTION and FinalClass to WARNING #1028

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Drop RedundantModifier to SUGGESTION and FinalClass to WARNING #1028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceb62a4
Drop RedundantModifier to SUGGESTION and FinalClass to WARNING
carterkozak Nov 6, 2019
7d6031f
Add generated changelog entries
carterkozak Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/FinalClass.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks",
linkType = BugPattern.LinkType.CUSTOM,
providesFix = BugPattern.ProvidesFix.REQUIRES_HUMAN_ATTENTION,
severity = BugPattern.SeverityLevel.ERROR,
severity = BugPattern.SeverityLevel.WARNING,
summary = "A class should be declared final if all of its constructors are private. Utility classes -- "
+ "i.e., classes all of whose methods and fields are static -- have a private, empty, "
+ "zero-argument constructor.\n"
Expand Down
2 changes: 1 addition & 1 deletion baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/RedundantModifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks",
linkType = BugPattern.LinkType.CUSTOM,
providesFix = BugPattern.ProvidesFix.REQUIRES_HUMAN_ATTENTION,
severity = BugPattern.SeverityLevel.ERROR,
severity = BugPattern.SeverityLevel.SUGGESTION,
summary = "Avoid using redundant modifiers")
public final class RedundantModifier extends BugChecker
implements BugChecker.ClassTreeMatcher, BugChecker.MethodTreeMatcher, BugChecker.VariableTreeMatcher {
Expand Down
9 changes: 9 additions & 0 deletions changelog/@unreleased/pr-1028.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
type: improvement
improvement:
description: |-
Drop RedundantModifier to SUGGESTION and FinalClass to WARNING

These checks don't imply bugs, and automation will fix failing cases automatically, so it's not necessary to block compilation.
FinalClass moved to warning rather than suggestion because there are a few edge cases (e.g. dependent projects using mockito without inline mock maker) where releases can run into issues if the bots don't fix findings in time.
links:
- https://github.com/palantir/gradle-baseline/pull/1028