Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Unsanitized regex breaking errorprone on windows paths #1045

Merged
merged 6 commits into from
Nov 15, 2019
Merged

Fix: Unsanitized regex breaking errorprone on windows paths #1045

merged 6 commits into from
Nov 15, 2019

Conversation

dansanduleac
Copy link
Contributor

Before this PR

Errorprone was breaking due to an unsatinized regex exclusion when using windows paths.
https://ci.appveyor.com/project/CRogers/gradle-conjure/builds/28845076

Caused by: java.util.regex.PatternSyntaxException: Unknown character property name {r} near index 4
C:\projects\gradle-conjure\gradle-conjure-api/(build|src/generated.*)/.*
^
at com.google.errorprone.ErrorProneOptions.processArgs(ErrorProneOptions.java:428)
at com.google.errorprone.ErrorProneOptions.processArgs(ErrorProneOptions.java:448)
at com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:45)

After this PR

==COMMIT_MSG==
Fix using errorprone when running under Windows.
==COMMIT_MSG==

Possible downsides?

@policy-bot policy-bot bot requested a review from ferozco November 15, 2019 13:57
carterkozak
carterkozak approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan

gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java Outdated
@@ -186,7 +187,7 @@ private static void configureErrorProneOptions(
errorProneOptions.setEnabled(true);
errorProneOptions.setDisableWarningsInGeneratedCode(true);
errorProneOptions.setExcludedPaths(
String.format("%s/(build|src/generated.*)/.*", project.getProjectDir().getPath()));
String.format("%s/(build|src/generated.*)/.*", Pattern.quote(project.getProjectDir().getPath())));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, this may produce a mix of forward and back slashes, but the jvm should handle that fine (assuming jre 1.5+!)

@iamdanfox iamdanfox changed the title Fix: Unsatinized regex breaking errorprone on windows paths Fix: Unsanitized regex breaking errorprone on windows paths Nov 15, 2019
@bulldozer-bot bulldozer-bot bot merged commit 42905a1 into develop Nov 15, 2019
@bulldozer-bot bulldozer-bot bot deleted the ds/unbreak-errorprone-windows branch November 15, 2019 17:09
@svc-autorelease
Copy link
Collaborator

Released 2.31.0

This was referenced Nov 15, 2019
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 15, 2019
Closed
Merged
Merged
Merged
Closed
Closed
Merged
Closed
This was referenced Nov 25, 2019
Closed
Closed
Closed
@iamdanfox iamdanfox mentioned this pull request Dec 13, 2019
Closed
This was referenced Dec 16, 2019
Closed
Merged
Closed
@svc-excavator-bot svc-excavator-bot mentioned this pull request Jan 6, 2020
Merged
This was referenced Jan 20, 2020
Merged
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak carterkozak approved these changes

@ferozco ferozco Awaiting requested review from ferozco

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dansanduleac @svc-autorelease @carterkozak