Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseline-class-uniqueness is updated by ./gradlew --write-locks #1153

Merged
merged 2 commits into from
Jan 9, 2020

Conversation

iamdanfox
Copy link
Contributor

Before this PR

Currently running ./gradlew --write-locks will not actually update people's baseline-class-uniqueness.lock file. (Amusingly I had this code locally, I just had forgotten to push it).

This is bad because many of our excavators rely on just running --write-locks after touching plugins, so they're currently red (e.g. onelogger on build2).

After this PR

==COMMIT_MSG==
Running ./gradlew --write-locks will now update the baseline-class-uniqueness.lock file.
==COMMIT_MSG==

Possible downsides?

The --write-locks invocation is quite a frequently invoked thing, and this makes it a little slower :/

@changelog-app
Copy link

changelog-app bot commented Jan 9, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Running ./gradlew --write-locks will now update the baseline-class-uniqueness.lock file.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from ferozco January 9, 2020 17:34
@iamdanfox iamdanfox requested review from dansanduleac and removed request for ferozco January 9, 2020 17:46
@bulldozer-bot bulldozer-bot bot merged commit 0f9d0d0 into develop Jan 9, 2020
@bulldozer-bot bulldozer-bot bot deleted the dfox/fix-write-locks-behaviour branch January 9, 2020 17:47
@svc-autorelease
Copy link
Collaborator

Released 2.48.1

This was referenced Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants