Fix 6.1 checkstyle report finalizer failure #1176
Conversation
…ngrade gradle back
Generate changelog in
|
| // not being on Gradle's classpath. So the best we can do to verify that the checkstyle actually ran is to | ||
| // verify we get the classpath error that happens when the checkstyle class runs :( | ||
| // https://github.com/gradle/gradle/issues/3995 | ||
| executionResult.standardError.contains 'java.lang.ClassNotFoundException: groovy.util.AntBuilder' |
There was a problem hiding this comment.
would it make sense to just not use nebula for this one test? i.e. to go through all the ProjectBuilder stuff manually?
There was a problem hiding this comment.
I don't think we can run with a specified gradle version without using nebula?
There was a problem hiding this comment.
This also happens in gradle test kit and the other 3rd party gradleTest framework :(
There was a problem hiding this comment.
There was a problem hiding this comment.
also if you disable debug it will not cause issues. Gradle test runner debug mode is a little too magical on your classpath
There was a problem hiding this comment.
Well, I gave using testkit/ProjectBuilder directly a go and I just couldn't get it to work (kept saying the existing code worked on Gradle 6.1) :( So this (or no test) may have to suffice.
This reverts commit 642a72b.
…radle-baseline into fix-junit-reportsw-gradle-6.1
…x-junit-reportsw-gradle-6.1
|
Released 2.49.2 |
Before this PR
See #1173 for a good explanation.
After this PR
==COMMIT_MSG==
Errors of the form
The value for Report xml property 'required' is final and cannot be changed any further.are now fixed for thecom.palantir.junit-reportsplugin.==COMMIT_MSG==
Possible downsides?
I had to change the configuration of the Checkstyle task to be set at configuration time rather than task runtime as it is being finalised. I think this is actually better though - I assume the previous way was to try and "force" despite any other configuration or because an older version of the API didn't use the Property API.
Fixes #1173.