fix #894: Error Prone UnnecessaryLambdaArgumentParentheses #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lambdas with a single parameter do not require argument parentheses. ```diff - (value) -> value != null + value -> value != null ```
Generate changelog in
|
|
pending testing on a large internal project |
|
We should also remove the existing checkstyle rule |
…com:palantir/gradle-baseline into ckozak/UnnecessaryLambdaArgumentParentheses
Good call, updated and increased the level to WARN. |
ferozco
reviewed
Jan 23, 2020
| link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks", | ||
| linkType = BugPattern.LinkType.CUSTOM, | ||
| providesFix = BugPattern.ProvidesFix.REQUIRES_HUMAN_ATTENTION, | ||
| severity = BugPattern.SeverityLevel.WARNING, |
There was a problem hiding this comment.
I think we should go with error since checkstyle previous enforced this
There was a problem hiding this comment.
Most projects fail on WARNING -- iirc we tried using ERROR for the BracesRequired check but ran into issues (possibly with generated code).
Since excavator will auto-fix anything in projects that don't fail on warnings, I don't think there's much risk.
|
👍 |
bulldozer-bot
bot
deleted the
ckozak/UnnecessaryLambdaArgumentParentheses
branch
|
Released 3.1.0 |
This was referenced Jan 23, 2020
This was referenced Jan 24, 2020
This was referenced Feb 5, 2020
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lambdas with a single parameter do not require argument parentheses.
After this PR
==COMMIT_MSG==
Lambdas with a single parameter do not require argument parentheses.
==COMMIT_MSG==
Possible downsides?
This is already validated by checkstyle, however checkstyle doesn't provide functionality to automatically fix occurrences.