Turn off UnnecessaryLambda check in tests #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
reviewed
Feb 4, 2020
gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Feb 4, 2020
| @@ -57,7 +57,8 @@ | |||
| "ArrayEquals", | |||
| "MissingOverride", | |||
| "UnnecessaryParentheses", | |||
| "PreferJavaTimeOverload"); | |||
| "PreferJavaTimeOverload", | |||
| "UnnecessaryLambda"); | |||
There was a problem hiding this comment.
I recall this creating code that didn’t compile, might want to test it on something large and internal (or atlas) first
There was a problem hiding this comment.
@dansanduleac you can use the hot new ./gradlew compileJava compileTestJava -PerrorProneApply=UnnecessaryLambda
There was a problem hiding this comment.
I've tested it on a project where this was causing trouble and it produced no fixes... if you recall this way, then maybe i can just remove it from here and let people deal with it
iamdanfox
approved these changes
Feb 4, 2020
|
Released 3.2.2 |
This was referenced Feb 4, 2020
This was referenced Feb 4, 2020
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
UnnecessaryLambda errorprone check blocking baseline in projects with
-Werror.After this PR
==COMMIT_MSG==
Turn off UnnecessaryLambda in tests where it doesn't provide value because there is a ubiquitous use case that is painful to fix.
==COMMIT_MSG==
Possible downsides?